Skip to content

Commit

Permalink
Merge pull request NixOS#7307 from hercules-ci/derivation-goal-improv…
Browse files Browse the repository at this point in the history
…e-comment

libstore/derivation-goal: Elaborate a TODO for performance concern
  • Loading branch information
thufschmitt authored Jan 6, 2023
2 parents 420ccec + bcd298d commit 8d88c3b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/libstore/build/derivation-goal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ void DerivationGoal::inputsRealised()
However, the impure derivations feature still relies on this
fragile way of doing things, because its builds do not have
a representation in the store, which is a usability problem
in itself */
in itself. When implementing this logic entirely with lookups
make sure that they're cached. */
if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) {
worker.store.computeFSClosure(*outPath, inputPaths);
}
Expand Down

0 comments on commit 8d88c3b

Please sign in to comment.