Missing flag

Reviewed By: @ldemailly, @uddipta

Differential Revision: D1886993

DirectorySourceQueue.cpp

@@ -264,14 +264,14 @@ void DirectorySourceQueue::createIntoQueue(const std::string &fullPath,
   // b) if filesize > blocksize, we can use send filename only in the first
   // block and use a shorter header for subsequent blocks. Also, we can remove
   // block size once negotiated, since blocksize is sort of fixed.
-
-  bool enableBlockTransfer = options_.block_size > 0;
+  int64_t blockSizeBytes = options_.block_size_mbytes * 1024 * 1024;
+  bool enableBlockTransfer = blockSizeBytes > 0;
   if (!enableBlockTransfer) {
     VLOG(2) << "Block transfer disabled for this transfer";
   }
   // if block transfer is disabled, treating fileSize as block size. This
   // ensures that we create a single block
-  auto blockSize = enableBlockTransfer ? options_.block_size : fileSize;
+  auto blockSize = enableBlockTransfer ? blockSizeBytes : fileSize;
 
   FileMetaData *fileData = new FileMetaData(fullPath, relPath, fileSize);
   sharedFileData_.emplace_back(fileData);

WdtFlags.cpp.inc

@@ -77,6 +77,9 @@ WDT_OPT(buffer_size, int32, "Buffer size (per thread/socket)");
 WDT_OPT(max_retries, int32, "how many attempts to connect/listen");
 WDT_OPT(max_transfer_retries, int32, "Max number of retries for a source");
 WDT_OPT(sleep_millis, int32, "how many ms to wait between attempts");
+WDT_OPT(block_size_mbytes, double,
+        "Size of the blocks that files will be divided in, specify negative "
+        "to disable the file splitting mode");
 WDT_OPT(retry_interval_mult_factor, double,
         "Factor to multiply with the retry interval for connnecting");
 WDT_OPT(avg_mbytes_per_sec, double,

WdtOptions.h

@@ -121,7 +121,7 @@ class WdtOptions {
   std::string prune_dir_regex{""};
 
   /**
-   * Maximu number of retries for transferring a file
+   * Maximum number of retries for transferring a file
    */
   int max_transfer_retries{3};
 
@@ -152,7 +152,7 @@ class WdtOptions {
    * block size, it is used to break bigger files into smaller chunks
    * block_size of <= 0 disables block transfer
    */
-  int64_t block_size{16 * 1024 * 1024};
+  double block_size_mbytes{16};
 
   /**
    * Since this is a singelton copy constructor