Skip to content

Commit

Permalink
apacheGH-34094: [C++] Increase Boost minimum version for clang >= 16 (a…
Browse files Browse the repository at this point in the history
…pache#34100)

### Rationale for this change

Build fails with older Boost on Clang >= 16

### Are there any user-facing changes?
No our dependency management will download the required Boost version if it is not installed on the system.
* Closes: apache#34094

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Neal Richardson <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
4 people authored Feb 10, 2023
1 parent 106568d commit 717d4fb
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,12 @@ macro(build_boost)
set(BOOST_VENDORED TRUE)
endmacro()

if(ARROW_BUILD_TESTS)
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER
15)
# GH-34094 Older versions of Boost use the deprecated std::unary_function in
# boost/container_hash/hash.hpp and support for that was removed in clang 16
set(ARROW_BOOST_REQUIRED_VERSION "1.81")
elseif(ARROW_BUILD_TESTS)
set(ARROW_BOOST_REQUIRED_VERSION "1.64")
else()
set(ARROW_BOOST_REQUIRED_VERSION "1.58")
Expand Down

0 comments on commit 717d4fb

Please sign in to comment.