-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to get project gems from GEM_PATH first #6
Conversation
This assumes that See #4 for more discussion about the speed issue. |
There is no such assumption. Multi projects can install gems to same |
Hmm, I guess I didn't look close enough. I'll put it through its paces on Monday. @bjeanes, would you give this a try as well? |
Sure, I'll try it out at work tomorrow |
Okay, I've had good results with the first commit. The two subsequent additions have not been so kind to me, and raise numerous concerns at any rate. They appear to be more along the lines of "make crude guesses based on common rvm practices." @bjeanes, how has it been working out for you? |
Honestly, I've spent the last 4 weeks in a world of managing teams and projects and not coding :( I'll chime in if/when I sit down and work on a Ruby app again, but as of know I don't have much to add, sadly... |
@tpope , yes, the last commits just guess the correct ruby version, it may be fail if there are some complex logic in .rvmrc. Ignore them are fine for me, or provide an option to disable detecting rvm automatically? |
I've sat on this for long enough. The first commit has been cherry-picked in. My uneasiness about the other two commits stands. Thanks! |
I think I've gotten feature parity with everything in the other two commits, with the possible exception of some edge cases around the rvm version. The only time it should be shelling out to bundler now is when their are platform specific gems in the mix, or you've explicitly done Open a new issue for further refinements. Thanks for steering me in the right direction, @zzzhc. |
Getting gem paths from ruby output is a little slow