Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to get project gems from GEM_PATH first #6

Closed
wants to merge 3 commits into from

Conversation

zzzhc
Copy link
Contributor

@zzzhc zzzhc commented Dec 10, 2011

Getting gem paths from ruby output is a little slow

@tpope
Copy link
Owner

tpope commented Dec 10, 2011

This assumes that $GEM_PATH contains only gems from the current bundle. Even the most OCD developers I know don't do rvm gemset empty every time they bundle install, so this is a very unsafe assumption.

See #4 for more discussion about the speed issue.

@tpope tpope closed this Dec 10, 2011
@zzzhc
Copy link
Contributor Author

zzzhc commented Dec 10, 2011

There is no such assumption. Multi projects can install gems to same $GEM_PATH, the pull request only detect whether $GEM_PATH/gems/gemname-version exists.

@tpope tpope reopened this Dec 10, 2011
@tpope
Copy link
Owner

tpope commented Dec 10, 2011

Hmm, I guess I didn't look close enough. I'll put it through its paces on Monday. @bjeanes, would you give this a try as well?

@bjeanes
Copy link

bjeanes commented Dec 11, 2011

Sure, I'll try it out at work tomorrow

@tpope
Copy link
Owner

tpope commented Dec 22, 2011

Okay, I've had good results with the first commit. The two subsequent additions have not been so kind to me, and raise numerous concerns at any rate. They appear to be more along the lines of "make crude guesses based on common rvm practices."

@bjeanes, how has it been working out for you?

@bjeanes
Copy link

bjeanes commented Dec 22, 2011

Honestly, I've spent the last 4 weeks in a world of managing teams and projects and not coding :(

I'll chime in if/when I sit down and work on a Ruby app again, but as of know I don't have much to add, sadly...

@zzzhc
Copy link
Contributor Author

zzzhc commented Dec 23, 2011

@tpope , yes, the last commits just guess the correct ruby version, it may be fail if there are some complex logic in .rvmrc. Ignore them are fine for me, or provide an option to disable detecting rvm automatically?

@tpope tpope mentioned this pull request Dec 28, 2011
@tpope
Copy link
Owner

tpope commented Jan 31, 2012

I've sat on this for long enough. The first commit has been cherry-picked in. My uneasiness about the other two commits stands.

Thanks!

@tpope
Copy link
Owner

tpope commented Feb 20, 2013

I think I've gotten feature parity with everything in the other two commits, with the possible exception of some edge cases around the rvm version. The only time it should be shelling out to bundler now is when their are platform specific gems in the mix, or you've explicitly done bundle --without. That information isn't in the lock file so I haven't decided on a solution for that yet.

Open a new issue for further refinements. Thanks for steering me in the right direction, @zzzhc.

@tpope tpope closed this Feb 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants