This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Make a new entry point for Next.js only #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to decouple Next.js completely.
|
Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel. @transitive-bullshit first needs to authorize it. |
BasixKOR
force-pushed
the
feat/optional-next
branch
from
1888327 to
b5482e5
Compare
BasixKOR
added a commit
to BasixKOR/basixpage
that referenced
this pull request
Feb 11, 2022
|
Hey @BasixKOR, thanks for the PR. I definitely like the approach & wasn't aware of Not sure how I feel about all the duplicated files, though. Going to spend some time considering options and get back to you. Thanks again 🙏 |
BasixKOR
added a commit
to BasixKOR/basixpage
that referenced
this pull request
Dec 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I just wanted to use this package really but I found that this package is tied to Next.js directly as discussed in #2.
This PR makes the
<Img>component to simple img tag with optionalreact-static-tweets/nextentry point that allows to use Next.js image optimization as usual.This PR is a breaking change. Existing users who want to keep using Next.js images should change their code to import from
react-static-tweets/nextinstead.