This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Use SWR's fallbackData #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel. @transitive-bullshit first needs to authorize it. |
transitive-bullshit
approved these changes
Jun 9, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks so much @shuding 🙏 I will follow-up by fixing the example build failure and getting an updated release out shortly. |
|
Successfully published: |
|
You're the 🐐s @shuding and @transitive-bullshit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the server side, the fetcher data is provided to SWR via a customized fetcher (
(id) => ast || twitter.tweetAstMap[id] || twitter.swrOptions.fetcher(id)). However SWR will not start data fetching on the server so the returned result will always beundefined.Because of that, the SSR result and the initial render (hydration) will be empty. And then it fetches the data and immediately return and render the provided data. Hence we have the #5 issue.
In this PR we upgrade SWR to the latest stable version and use the
fallbackDatafield to provide the SSR'd data to SWR. With this SWR doesn't need to fetch on the server side but can also return the value as a fallback. Docs can be found in https://swr.vercel.app/docs/prefetching#pre-fill-data.Closes #5.