rgw: DefaultRetention requires either Days or Years

Fixes: https://tracker.ceph.com/issues/41838 Signed-off-by: Chang Liu <[email protected]>
travisn · Sep 16, 2019 · a412849 · a412849
1 parent 49addda
commit a412849
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/rgw/rgw_object_lock.h b/src/rgw/rgw_object_lock.h
@@ -109,7 +109,10 @@ class RGWObjectLock
   }
 
   bool retention_period_valid() const {
-    return (get_years() > 0 || get_days() > 0);
+    // DefaultRetention requires either Days or Years.
+    // You can't specify both at the same time.
+    // see https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTObjectLockConfiguration.html
+    return get_years() > 0 != get_days() > 0;
   }
 
   bool has_rule() const {