Skip to content

Commit

Permalink
Fix undefined warning messages in GCC 6.
Browse files Browse the repository at this point in the history
    GCC 6 puts out warnings in a different location then GCC 5.  Move the
    DIAG macros so that the warnings are supressed for both compilers.

    ChangeLog:

	* soft-fp/fmasf4.c: Add include of sys/cdefs.h.
	Move DIAG_PUSH_NEEDS_COMMENT, DIAG_IGNORE_NEEDS_COMMENT to front of
	file, move DIAG_POP_NEEDS_COMMENT to end of file.
	* soft-fp/fmadf4.c: Ditto.
	* soft-fp/fmatf4.c: Ditto.
  • Loading branch information
Steve Ellcey committed Aug 27, 2015
1 parent ae85721 commit 3743036
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 33 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2015-08-27 Steve Ellcey <[email protected]>

* soft-fp/fmasf4.c: Add include of sys/cdefs.h.
Move DIAG_PUSH_NEEDS_COMMENT, DIAG_IGNORE_NEEDS_COMMENT to front of
file, move DIAG_POP_NEEDS_COMMENT to end of file.
* soft-fp/fmadf4.c: Ditto.
* soft-fp/fmatf4.c: Ditto.

2015-08-27 H.J. Lu <[email protected]>

* sysdeps/i386/i586/Implies: Removed.
Expand Down
26 changes: 15 additions & 11 deletions soft-fp/fmadf4.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@
<http://www.gnu.org/licenses/>. */

#include <libc-internal.h>
#include <sys/cdefs.h>
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used uninitialized.
The location of the warning differs in different versions of GCC,
it may be where R is defined using a macro or it may be where the
macro is defined. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
#include <math.h>
#include "soft-fp.h"
#include "double.h"
Expand All @@ -45,22 +58,13 @@ __fma (double a, double b, double c)
FP_UNPACK_D (B, b);
FP_UNPACK_D (C, c);
FP_FMA_D (R, A, B, C);
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used
uninitialized. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
FP_PACK_D (r, R);
DIAG_POP_NEEDS_COMMENT;
FP_HANDLE_EXCEPTIONS;

return r;
}
DIAG_POP_NEEDS_COMMENT;

#ifndef __fma
weak_alias (__fma, fma)
#endif
Expand Down
26 changes: 15 additions & 11 deletions soft-fp/fmasf4.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@
<http://www.gnu.org/licenses/>. */

#include <libc-internal.h>
#include <sys/cdefs.h>
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used uninitialized.
The location of the warning differs in different versions of GCC,
it may be where R is defined using a macro or it may be where the
macro is defined. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
#include <math.h>
#include "soft-fp.h"
#include "single.h"
Expand All @@ -45,22 +58,13 @@ __fmaf (float a, float b, float c)
FP_UNPACK_S (B, b);
FP_UNPACK_S (C, c);
FP_FMA_S (R, A, B, C);
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used
uninitialized. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
FP_PACK_S (r, R);
DIAG_POP_NEEDS_COMMENT;
FP_HANDLE_EXCEPTIONS;

return r;
}
DIAG_POP_NEEDS_COMMENT;

#ifndef __fmaf
weak_alias (__fmaf, fmaf)
#endif
26 changes: 15 additions & 11 deletions soft-fp/fmatf4.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@
<http://www.gnu.org/licenses/>. */

#include <libc-internal.h>
#include <sys/cdefs.h>
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used uninitialized.
The location of the warning differs in different versions of GCC,
it may be where R is defined using a macro or it may be where the
macro is defined. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
#include <math.h>
#include "soft-fp.h"
#include "quad.h"
Expand All @@ -45,20 +58,11 @@ __fmal (long double a, long double b, long double c)
FP_UNPACK_Q (B, b);
FP_UNPACK_Q (C, c);
FP_FMA_Q (R, A, B, C);
/* R_e is not set in cases where it is not used in packing, but the
compiler does not see that it is set in all cases where it is
used, resulting in warnings that it may be used
uninitialized. */
DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (4, 7)
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
#else
DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
#endif
FP_PACK_Q (r, R);
DIAG_POP_NEEDS_COMMENT;
FP_HANDLE_EXCEPTIONS;

return r;
}
DIAG_POP_NEEDS_COMMENT;

weak_alias (__fmal, fmal)

0 comments on commit 3743036

Please sign in to comment.