Add checking win.HTMLElement in isHTMLElement

trevorlolsen · Sep 24, 2016 · af4f75e · af4f75e
1 parent b7da107
commit af4f75e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/leader-line.js b/src/leader-line.js
@@ -335,7 +335,7 @@
 
   function isHTMLElement(element) {
     var win, doc;
-    return !!(element && (doc = element.ownerDocument) && (win = doc.defaultView) &&
+    return !!(element && (doc = element.ownerDocument) && (win = doc.defaultView) && win.HTMLElement &&
       element instanceof win.HTMLElement);
   }
   window.isHTMLElement = isHTMLElement; // [DEBUG/]

diff --git a/test/spec/funcs.js b/test/spec/funcs.js
@@ -600,6 +600,19 @@ describe('funcs', function() {
       }
       expect(isHTMLElement(element)).toBe(false);
     });
+
+    it('other types:false', function() {
+      expect(isHTMLElement('a')).toBe(false);
+      expect(isHTMLElement(1)).toBe(false);
+      expect(isHTMLElement('')).toBe(false);
+      expect(isHTMLElement(0)).toBe(false);
+      expect(isHTMLElement(null)).toBe(false);
+      expect(isHTMLElement()).toBe(false);
+      expect(isHTMLElement({})).toBe(false);
+      expect(isHTMLElement(true)).toBe(false);
+      expect(isHTMLElement(window)).toBe(false);
+      expect(isHTMLElement(new Date())).toBe(false);
+    });
   });
 
 });