Skip to content

Commit

Permalink
Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248]
Browse files Browse the repository at this point in the history
The original intent behind this is unclear.  It interferes with flags
that has to be ordered in a particular way.
  • Loading branch information
fweimer-rh committed Aug 21, 2018
1 parent ef939d9 commit c7627f4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2018-08-21 Florian Weimer <[email protected]>

[BZ #17248]
* Makeconfig (+cflags): Do not sort (and deduplicate).

2018-08-21 Florian Weimer <[email protected]>

* debug/readlink_chk.c (__readlink_chk): Always call __readlink.
Expand Down
3 changes: 0 additions & 3 deletions Makeconfig
Original file line number Diff line number Diff line change
Expand Up @@ -902,9 +902,6 @@ endif # $(+cflags) == ""
$(+stack-protector)
+gcc-nowarn := -w

# Don't duplicate options if we inherited variables from the parent.
+cflags := $(sort $(+cflags))

# Each sysdeps directory can contain header files that both will be
# used to compile and will be installed. Each can also contain an
# include/ subdirectory, whose header files will be used to compile
Expand Down

0 comments on commit c7627f4

Please sign in to comment.