fix: legacyDevProcessCwdBehaviour defaults to true #2387

ericallam · 2025-08-13T13:22:12Z

This fixes an issue with prisma not being able to locate the native
add-on binary

This fixes an issue with prisma not being able to locate the native add-on binary

changeset-bot · 2025-08-13T13:22:17Z

🦋 Changeset detected

Latest commit: 4427817

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-08-13T13:22:21Z

Walkthrough

Introduces a changeset for a patch release changing the default of legacyDevProcessCwdBehaviour from false to true.
In devSupervisor.ts, replaces direct boolean access with an explicit computed boolean that defaults to true when unset/non-boolean, and adjusts cwd: true → undefined, false → worker.build.outputPath.
Updates JSDoc in config to reflect the new default (@default true) and clarify behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/legacy-dev-cwd-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

.changeset/afraid-waves-divide.md (1)
5-5: Tighten the changeset summary wording and formatting.

Clarify the intent and format identifiers as code for readability.

Apply this diff:
-Make the default of legacyDevProcessCwdBehaviour true instead of false (prevents breaking prismaExtension)
+Make the default of `legacyDevProcessCwdBehaviour` true instead of false. This prevents breaking the Prisma native add-on resolution (e.g. the `prismaExtension`) in dev.
packages/core/src/v3/config.ts (1)
286-288: Avoid contradictory guidance: soften the “highly recommended” note or add context.

Default is now true for compatibility (e.g., Prisma), but the current wording recommends false as “highly recommended,” which can confuse users. Recommend softening and adding context about native modules.

Apply this diff:
-   * Setting this to `false` will set the current working directory to the build directory.
-   * This more closely matches the behavior of the CLI when running in production and is highly recommended.
+   * Setting this to `false` will set the current working directory to the build directory.
+   * This more closely matches the behavior of the CLI when running in production.
+   * Note: Some native modules (e.g. Prisma) may expect the project root as the CWD during development; in those cases keep this set to `true`.
packages/cli-v3/src/dev/devSupervisor.ts (1)
361-367: Prefer nullish coalescing for simpler defaulting.

TypeScript already types legacyDevProcessCwdBehaviour as boolean | undefined. Using the nullish coalescing operator simplifies the logic without changing semantics.

Apply this diff:
-        const legacyDevProcessCwdBehaviour =
-          typeof this.options.config.legacyDevProcessCwdBehaviour === "boolean"
-            ? this.options.config.legacyDevProcessCwdBehaviour
-            : true;
+        const legacyDevProcessCwdBehaviour =
+          this.options.config.legacyDevProcessCwdBehaviour ?? true;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed07bf9 and 4427817.

📒 Files selected for processing (3)

.changeset/afraid-waves-divide.md (1 hunks)
packages/cli-v3/src/dev/devSupervisor.ts (1 hunks)
packages/core/src/v3/config.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Always prefer using isomorphic code like fetch, ReadableStream, etc. instead of Node.js specific code
For TypeScript, we usually use types over interfaces
Avoid enums
No default exports, use function declarations

Files:

packages/cli-v3/src/dev/devSupervisor.ts
packages/core/src/v3/config.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

We use zod a lot in packages/core and in the webapp

Files:

packages/core/src/v3/config.ts

🧠 Learnings (5)