Skip to content

chore(bun): upgrade to bun v1.2.20 #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

chore(bun): upgrade to bun v1.2.20 #2398

merged 1 commit into from
Aug 15, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Aug 14, 2025

No description provided.

Copy link

changeset-bot bot commented Aug 14, 2025

🦋 Changeset detected

Latest commit: b18c049

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 14, 2025

Walkthrough

  • Added .changeset/mean-wolves-stare.md declaring a patch release for "trigger.dev" to upgrade Bun to v1.2.20.
  • Updated BASE_IMAGE in packages/cli-v3/src/deploy/buildImage.ts to use imbios/bun-node:1.2.20-20-slim with a new sha256 digest.
  • Node and node-22 base images remain unchanged.
  • No control flow, error handling, or public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f767654 and b18c049.

📒 Files selected for processing (2)
  • .changeset/mean-wolves-stare.md (1 hunks)
  • packages/cli-v3/src/deploy/buildImage.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Always prefer using isomorphic code like fetch, ReadableStream, etc. instead of Node.js specific code
For TypeScript, we usually use types over interfaces
Avoid enums
No default exports, use function declarations

Files:

  • packages/cli-v3/src/deploy/buildImage.ts
🔇 Additional comments (2)
.changeset/mean-wolves-stare.md (1)

1-5: Changeset for Bun upgrade — LGTM

Patch bump and message are clear and match the PR scope.

packages/cli-v3/src/deploy/buildImage.ts (1)

546-546: Bun base image bumped to 1.2.20 — please confirm the pinned digest is multi-arch (amd64/arm64)

Given we support multi-platform builds (see ensureQemuRegistered and buildx usage), ensure the pinned digest resolves to a manifest list that includes linux/amd64 and linux/arm64. If it’s a single-arch image digest, multi-arch builds may fail. If necessary, switch to the manifest-list digest for this tag or drop the digest pin and rely on the tag.

Action items:

  • Verify that imbios/bun-node:1.2.20-20-slim@sha256:a20d1f90... supports both linux/amd64 and linux/arm64.
  • If not, update to a manifest-list digest or remove the digest pin.
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-bun

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit a76905e into main Aug 15, 2025
31 checks passed
@matt-aitken matt-aitken deleted the chore/upgrade-bun branch August 15, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants