MueLu: Fix node-based interface aggregation for >1 DoFs per dual node #13859
+219,802
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
…d test Signed-off-by: Philip Oesterle-Pekrun <[email protected]>
PhilipOesterlePekrun
force-pushed
the
develop
branch
from
4252462 to
efa210e
Compare
cgcgcg
reviewed
Mar 8, 2025
There was a problem hiding this comment.
Can we use a smaller matrix for the test?
cgcgcg
reviewed
Mar 8, 2025
There was a problem hiding this comment.
I would encourage you to use Kokkos data structures where possible for new code.
|
@PhilipOesterlePekrun @mayrmt I would personally like to see a unit test, which directly tests the implemented functionality with it's dedicated input and output. The framework test is a nice addition, but doesn't exactly proof if the implementation is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/muelu
Motivation
In the current state, it was found that the interface aggregation algorithm, which is based on a dual node to primal node mapping, fails for block matrix systems with dual (Lagrange multiplier) nodes with greater than 1 degree of freedom.
Description
This commit fixes the issue by adding dual amalgamation info and fixing the computation of the dual node map. The necessary structure of the input ParameterLists for this case required a slight adaptation as well.
Testing
A mesh tying test,
MeshTyingBlocked_NodeBased_simpleSmoother_3dualDofs, is included in this commit and works in serial and in parallel (MPI_1, MPI_4).@mayrmt
@maxfirmbach