crimson/onode-staged-tree: allow non-empty DeltaRecorder to be destru…

…cted Fixes: http://tracker.ceph.com/issues/50028 Signed-off-by: Yingxin Cheng <[email protected]>
trociny · Mar 29, 2021 · 01a8c5a · 01a8c5a
1 parent 6049793
commit 01a8c5a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/crimson/os/seastore/onode_manager/staged-fltree/node_delta_recorder.h b/src/crimson/os/seastore/onode_manager/staged-fltree/node_delta_recorder.h
@@ -18,7 +18,10 @@ namespace crimson::os::seastore::onode {
 class DeltaRecorder {
  public:
   virtual ~DeltaRecorder() {
-    assert(is_empty());
+    /* May be non-empty if transaction is abandoned without
+     * being submitted -- conflicts are a particularly common
+     * example (denoted generally by returning crimson::ct_error::eagain).
+     */
   }
 
   bool is_empty() const {