osd/PGLog: trim - avoid dereferencing invalid iter

Log(e.g., projected_log) could theoretically be emtpy and hence there might be potential access violation. Signed-off-by: xie xingguo <[email protected]>
trociny · Aug 18, 2018 · 19a5c37 · 19a5c37
1 parent 0ef08e1
commit 19a5c37
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/osd/PGLog.cc b/src/osd/PGLog.cc
@@ -100,9 +100,13 @@ void PGLog::IndexedLog::trim(
 
     // reset complete_to to the beginning of the log
     if (reset_complete_to) {
-      lgeneric_subdout(cct, osd, 20) << " moving complete_to " << " to "
-                      << log.begin()->version << dendl;
       complete_to = log.begin();
+      if (complete_to != log.end()) {
+        lgeneric_subdout(cct, osd, 20) << " moving complete_to to "
+                                       << log.begin()->version << dendl;
+      } else {
+        lgeneric_subdout(cct, osd, 20) << " log is now empty" << dendl;
+      }
     }
   }