-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
systemd: Support Graceful Reboot for AIO Node
Ceph AIO installation with single/multiple node is not friendly for loopback mount, especially always get deadlock issue during graceful system reboot. We already have `rbdmap.service` with graceful system reboot friendly as below: [Unit] After=network-online.target Before=remote-fs-pre.target Wants=network-online.target remote-fs-pre.target [Service] ExecStart=/usr/bin/rbdmap map ExecReload=/usr/bin/rbdmap map ExecStop=/usr/bin/rbdmap unmap-all This PR introduce: - `ceph-mon.target`: Ensure startup after `network-online.target` and before `remote-fs-pre.target` - `ceph-*.target`: Ensure startup after `ceph-mon.target` and before `remote-fs-pre.target` - `rbdmap.service`: Once all `_netdev` get unmount by `remote-fs.target`, ensure unmap all RBD BEFORE any Ceph components under `ceph.target` get stopped during shutdown The logic is concept proof by <https://github.com/alvistack/ansible-role-ceph_common/tree/develop>; also works as expected with Ceph + Kubernetes deployment by <https://github.com/alvistack/ansible-collection-kubernetes/tree/develop>. No more deadlock happened during graceful system reboot, both AIO single/multiple no de with loopback mount. Also see: - <ceph#36776> - <etcd-io/etcd#12259> - <cri-o/cri-o#4128> - <kubernetes/release#1504> Fixes: https://tracker.ceph.com/issues/47528 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
- Loading branch information
Showing
15 changed files
with
35 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,6 @@ | |
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
Before=ceph.target | ||
|
||
[Install] | ||
WantedBy=remote-fs.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,6 @@ | |
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
Before=ceph.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
[Unit] | ||
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
After=ceph-mon.target | ||
Before=ceph.target | ||
Wants=ceph.target ceph-mon.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
[Unit] | ||
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
After=ceph-mon.target | ||
Before=ceph.target | ||
Wants=ceph.target ceph-mon.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,7 @@ | |
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
Before=ceph.target | ||
Wants=ceph.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
[Unit] | ||
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
After=ceph-mon.target | ||
Before=ceph.target | ||
Wants=ceph.target ceph-mon.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
[Unit] | ||
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
After=ceph-mon.target | ||
Before=ceph.target | ||
Wants=ceph.target ceph-mon.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,6 @@ | |
Description=ceph target allowing to start/stop all [email protected] instances at once | ||
PartOf=ceph.target | ||
Before=ceph.target | ||
|
||
[Install] | ||
WantedBy=multi-user.target ceph.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
[Unit] | ||
Description=ceph target allowing to start/stop all ceph*@.service instances at once | ||
|
||
[Install] | ||
WantedBy=multi-user.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters