Recognize Meta+Left and Meta+Right for word navigation
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lf-
reviewed
Sep 9, 2024
I'm not sure exactly where to find canonical documentation for these codes, but this seems to match what my terminal produces (macOS + iTerm2 + Fish + Tmux). It might also be nice to have some more support for editing the bindings for these characters; sequences of more than one character are not supported by `el_bind_key` and similar.
9999years
force-pushed
the
recognize-meta-arrows
branch
from
9fedc90
to
d0f2a5b
Compare
|
If you are looking for a reference for terminal codes, see: https://terminalguide.namepad.de/ |
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 11, 2024
This applies troglobit/editline#70 to our build of editline, which translates `meta-left` and `meta-right` into `fd_word` and `bk_word`. This makes `nix repl` soooo much nicer to use! Note: My terminal renders `meta-left` as `\e\e[C` and `meta-right` as `\e\e[D`. Closes https://git.lix.systems/lix-project/lix/issues/501 Change-Id: I048b10cf17231bbf4e6bf38e1d1d8572cedaa194
9999years
added a commit
to 9999years/nixpkgs
that referenced
this pull request
Sep 11, 2024
Lix has applied this patch upstream in order to recognize `Alt+Left` and `Alt+Right` for word navigation in `nix repl` on more terminals. If this is merged into `editline` upstream I'll update `editline` in Nixpkgs and then we can drop this patch. See: troglobit/editline#70 See: https://gerrit.lix.systems/c/lix/+/1883
13 tasks
9999years
added a commit
to 9999years/nixpkgs
that referenced
this pull request
Sep 11, 2024
Lix has applied this patch upstream in order to recognize `Alt+Left` and `Alt+Right` for word navigation in `nix repl` on more terminals. If this is merged into `editline` upstream I'll update `editline` in Nixpkgs and then we can drop this patch. See: troglobit/editline#70 See: https://gerrit.lix.systems/c/lix/+/1883
9999years
added a commit
to 9999years/nixpkgs
that referenced
this pull request
Sep 11, 2024
Lix has applied this patch upstream in order to recognize `Alt+Left` and `Alt+Right` for word navigation in `nix repl` on more terminals. If this is merged into `editline` upstream I'll update `editline` in Nixpkgs and then we can drop this patch. See: troglobit/editline#70 See: https://gerrit.lix.systems/c/lix/+/1883
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 11, 2024
This vendors the patch added in cl/1883 to avoid GitHub garbage-collecting the commits we're referring to. As @emilazy pointed out on GitHub: > GitHub can garbage‐collect unmerged PR commits if they are later > force‐pushed, which means that code review in upstreams can cause > Nixpkgs builds to fail to reproduce in future. See: NixOS/nixpkgs#341131 (comment) See: troglobit/editline#70 See: https://gerrit.lix.systems/c/lix/+/1883 Change-Id: Ifff522f7f23310d6dbe9efc72fd40be5500ae872
|
@troglobit Still looking for a review on this, thanks! |
|
I'll try to make some time this coming weekend, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly where to find canonical documentation for these codes, but this seems to match what my terminal produces (macOS + iTerm2+ Fish + Tmux).
It might also be nice to have some more support for editing the bindings for these characters; sequences of more than one character are not supported by
el_bind_keyand similar.See: https://git.lix.systems/lix-project/lix/issues/501