forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds tests and storybook to CopyToClipboard component (apache#13359)
- Loading branch information
1 parent
7d270bc
commit e9d5d3b
Showing
12 changed files
with
181 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
superset-frontend/spec/javascripts/components/CopyToClipboard_spec.jsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
superset-frontend/src/components/CopyToClipboard/CopyToClipboard.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import Button from 'src/components/Button'; | ||
| import Icon from 'src/components/Icon'; | ||
| import ToastPresenter from 'src/messageToasts/containers/ToastPresenter'; | ||
| import CopyToClipboard from '.'; | ||
|
|
||
| export default { | ||
| title: 'CopyToClipboard', | ||
| component: CopyToClipboard, | ||
| }; | ||
|
|
||
| export const InteractiveCopyToClipboard = ({ copyNode, ...rest }: any) => { | ||
| let node = <Button>Copy</Button>; | ||
| if (copyNode === 'Icon') { | ||
| node = <Icon name="copy" />; | ||
| } else if (copyNode === 'Text') { | ||
| node = <span role="button">Copy</span>; | ||
| } | ||
| return ( | ||
| <> | ||
| <CopyToClipboard copyNode={node} {...rest} /> | ||
| <ToastPresenter /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| InteractiveCopyToClipboard.args = { | ||
| shouldShowText: true, | ||
| text: 'http://superset.apache.org/', | ||
| wrapped: true, | ||
| tooltipText: 'Copy to clipboard', | ||
| }; | ||
|
|
||
| InteractiveCopyToClipboard.argTypes = { | ||
| onCopyEnd: { action: 'onCopyEnd' }, | ||
| copyNode: { | ||
| defaultValue: 'Button', | ||
| control: { type: 'radio', options: ['Button', 'Icon', 'Text'] }, | ||
| }, | ||
| }; | ||
|
|
||
| InteractiveCopyToClipboard.story = { | ||
| parameters: { | ||
| knobs: { | ||
| disable: true, | ||
| }, | ||
| }, | ||
| }; |
76 changes: 76 additions & 0 deletions
76
superset-frontend/src/components/CopyToClipboard/CopyToClipboard.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { render, screen, waitFor } from 'spec/helpers/testing-library'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import CopyToClipboard from '.'; | ||
|
|
||
| test('renders with default props', () => { | ||
| const text = 'Text'; | ||
| render(<CopyToClipboard text={text} />, { useRedux: true }); | ||
| expect(screen.getByText(text)).toBeInTheDocument(); | ||
| expect(screen.getByText('Copy')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('renders with custom copy node', () => { | ||
| const copyNode = <a href="/">Custom node</a>; | ||
| render(<CopyToClipboard copyNode={copyNode} />, { useRedux: true }); | ||
| expect(screen.getByRole('link')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('renders without text showing', () => { | ||
| const text = 'Text'; | ||
| render(<CopyToClipboard text={text} shouldShowText={false} />, { | ||
| useRedux: true, | ||
| }); | ||
| expect(screen.queryByText(text)).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('getText on copy', async () => { | ||
| const getText = jest.fn(() => 'Text'); | ||
| render(<CopyToClipboard getText={getText} />, { useRedux: true }); | ||
| userEvent.click(screen.getByText('Copy')); | ||
| await waitFor(() => expect(getText).toHaveBeenCalled()); | ||
| }); | ||
|
|
||
| test('renders tooltip on hover', async () => { | ||
| const tooltipText = 'Tooltip'; | ||
| render(<CopyToClipboard tooltipText={tooltipText} />, { useRedux: true }); | ||
| userEvent.hover(screen.getByText('Copy')); | ||
| const tooltip = await screen.findByRole('tooltip'); | ||
| expect(tooltip).toBeInTheDocument(); | ||
| expect(tooltip).toHaveTextContent(tooltipText); | ||
| }); | ||
|
|
||
| test('triggers onCopyEnd', async () => { | ||
| const onCopyEnd = jest.fn(); | ||
| render(<CopyToClipboard onCopyEnd={onCopyEnd} />, { | ||
| useRedux: true, | ||
| }); | ||
| userEvent.click(screen.getByText('Copy')); | ||
| await waitFor(() => expect(onCopyEnd).toHaveBeenCalled()); | ||
| }); | ||
|
|
||
| test('renders unwrapped', () => { | ||
| const text = 'Text'; | ||
| render(<CopyToClipboard text={text} wrapped={false} />, { | ||
| useRedux: true, | ||
| }); | ||
| expect(screen.queryByText(text)).not.toBeInTheDocument(); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters