Skip to content

Commit

Permalink
Improve aliasify usage
Browse files Browse the repository at this point in the history
  • Loading branch information
pandamicro committed Mar 29, 2018
1 parent 729fa55 commit 9fdde9f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 18 deletions.
28 changes: 12 additions & 16 deletions gulp/tasks/engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ var jsbSkipModules = [
'../../cocos2d/audio/CCAudio',
'../../external/box2d/box2d.js',
];
var aliasifyConfig = {
replacements: {
'(.*)render-engine(.js)?': './cocos2d/core/renderer/render-engine.jsb'
},
verbose: false
};

exports.buildCocosJs = function (sourceFile, outputFile, excludes, opt_macroFlags, callback) {
if (typeof opt_macroFlags === 'function') {
Expand Down Expand Up @@ -211,14 +217,9 @@ exports.buildJsb = function (sourceFile, outputFile, excludes, opt_macroFlags, c
var outFile = Path.basename(outputFile);
var outDir = Path.dirname(outputFile);

var aliasifyConfig = {
replacements: {
'(.*)render-engine(.js)?': './cocos2d/core/renderer/render-engine.jsb'
},
verbose: false
}

var bundler = createBundler(sourceFile, null, aliasifyConfig);
var bundler = createBundler(sourceFile, {
aliasifyConfig: aliasifyConfig
});
excludes = excludes.concat(jsbSkipModules);
excludes.forEach(function (module) {
bundler.ignore(require.resolve(module));
Expand Down Expand Up @@ -248,14 +249,9 @@ exports.buildJsbMin = function (sourceFile, outputFile, excludes, opt_macroFlags
var outFile = Path.basename(outputFile);
var outDir = Path.dirname(outputFile);

var aliasifyConfig = {
replacements: {
'(.*)render-engine(.js)?': './cocos2d/core/renderer/render-engine.jsb'
},
verbose: false
}

var bundler = createBundler(sourceFile, null, aliasifyConfig);
var bundler = createBundler(sourceFile, {
aliasifyConfig: aliasifyConfig
});
excludes = excludes.concat(jsbSkipModules);
excludes.forEach(function (module) {
bundler.ignore(require.resolve(module));
Expand Down
4 changes: 2 additions & 2 deletions gulp/util/create-bundler.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function allowReturnOutsideFunctionInBrowserifyTransform () {
* @param [options.babelifyOpt]
* @param [options.aliasifyConfig]
*/
module.exports = function createBundler(entryFiles, options, aliasifyConfig) {
module.exports = function createBundler(entryFiles, options) {
// https://github.com/substack/node-browserify#methods
var browserifyOpt = {
entries: [].concat(entryFiles),
Expand Down Expand Up @@ -133,5 +133,5 @@ module.exports = function createBundler(entryFiles, options, aliasifyConfig) {
sourceMaps: true,
compact: false
})
.transform(aliasify, aliasifyConfig);
.transform(aliasify, (options && options.aliasifyConfig) || {});
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"jshint-stylish": "2.1.0",
"multipipe": "0.3.0",
"persistify": "^1.1.1",
"aliasify": "^2.1.0",
"require-dir": "0.3.0",
"uglify-es": "3.3.7",
"vinyl": "1.1.0",
Expand Down

0 comments on commit 9fdde9f

Please sign in to comment.