Fix for JavaScript's broken Date API.

tunnij · Sep 4, 2012 · 8000976 · 8000976
1 parent ce502a4
commit 8000976
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/d3.v2.js b/d3.v2.js
@@ -6918,8 +6918,8 @@
   d3.time.hours = d3.time.hour.range;
   d3.time.hours.utc = d3.time.hour.utc.range;
   d3.time.day = d3_time_interval(function(date) {
-    var day = new d3_time(0, date.getMonth(), date.getDate());
-    day.setFullYear(date.getFullYear());
+    var day = new d3_time(1970, 0);
+    day.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
     return day;
   }, function(date, offset) {
     date.setDate(date.getDate() + offset);

diff --git a/d3.v2.min.js b/d3.v2.min.js
diff --git a/src/time/day.js b/src/time/day.js
@@ -1,6 +1,6 @@
 d3.time.day = d3_time_interval(function(date) {
-  var day = new d3_time(0, date.getMonth(), date.getDate());
-  day.setFullYear(date.getFullYear());
+  var day = new d3_time(1970, 0);
+  day.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
   return day;
 }, function(date, offset) {
   date.setDate(date.getDate() + offset);

diff --git a/test/time/day-test.js b/test/time/day-test.js
@@ -61,6 +61,10 @@ suite.addBatch({
         assert.deepEqual(ceil(utc(2011, 10, 06, 08)), local(2011, 10, 07));
         assert.deepEqual(ceil(utc(2011, 10, 06, 09)), local(2011, 10, 07));
         assert.deepEqual(ceil(utc(2011, 10, 06, 10)), local(2011, 10, 07));
+      },
+      "handles midnight for leap years": function(ceil) {
+        assert.deepEqual(ceil(utc(2012, 02, 01, 00)), local(2012, 02, 01));
+        assert.deepEqual(ceil(utc(2012, 02, 01, 00)), local(2012, 02, 01));
       }
     },
     "offset": {