cli: Introduce a selectable IO backend with --io={syscall,io-uring} argument #654
+107
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… revert on every commit is not fun.
…ngIO on Linux with feature io_uring. cli: add a new argument to select I/O backend (more than one option only for Linux with io_uring feature). cli: make both Limbo::new() and Limbo::open_db() use get_io(), unifying parsing of database path and eliminating duplicated code.
…that the correct one has been selected.
LtdJorge
force-pushed
the
selectable-io-backend
branch
from
2409bc4 to
5a45df8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Ah, I get it now after taking a look at your history. You're just spamming the same comments on multiple projects... |
PThorpe92
reviewed
Jan 11, 2025
PThorpe92
reviewed
Jan 11, 2025
PThorpe92
reviewed
Jan 11, 2025
…emory we get a default Io from Clap. Also remove last pesky Io::clone()
PThorpe92
approved these changes
Jan 11, 2025
Yeah, neither am I. It is what Pekka suggested in #628 so I went with it. Thanks for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the user the option of choosing IO backend. There is only a "syscall" backend, unless built for Linux with
#[cfg(feature = "io_uring")]which introduces--io=io-uring.Right now, the choice has only been implemented for the CLI. Bindings and such default to PlatformIO, except when an "in-memory" database has been chosen.
Can be tested by running CLI with RUST_LOG=debug