Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error callback for when images requests fail #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Error callback for when images requests fail #217

wants to merge 1 commit into from

Conversation

travisdahl
Copy link

It would be nice to have a "failed" event too if image request failed. For instance in my app I am adding a ".loaded" class to images that have finished using the 'load' event and then for various reasons i am periodically checking to see if all images were loaded, but if an image failed '404' then my check runs infinitely. If there was a 'failed' event I could add a failed class or even a 'loaded' class, but something to know that the plugin itself ran, but the image request failed. Does that make sense?

@tusharmath
Copy link

@tuupola Please merge this. This is a very relevant pull request.

@dmccabe
Copy link

dmccabe commented May 21, 2015

+1. This would be very useful to have.

@tuupola tuupola self-assigned this Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants