Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: last updates #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: last updates #42

wants to merge 6 commits into from

Conversation

RaulGF92
Copy link

No description provided.

@RaulGF92
Copy link
Author

RaulGF92 commented Jun 25, 2021

Hi! I've created a distribution for desktop applications. If you could see you only must go to PR and run:

npm run electron

And an IPOD going to appears at the top of the right of your desktop!

For me, your project is so cool bro, but I don't have an Apple Dev account for your app is blocked for me in localhost mode. Could you try and say me if you like?

Also, I've integrated the electron-package for you could create distribution in SO you like, if you like me contribution and you like to introduce to your project, It will perfect if you shared with me a Ubuntu distribution : (

you only need to put

npm run electron-package

We could talk more of this across the PR

Best Regards!

@mankybansal
Copy link
Collaborator

mankybansal commented Jun 25, 2021

Hi @RaulGF92, this is great! Can you remove the package-lock.json and use yarn instead?

@tvillarete
Copy link
Owner

This is fantastic! I had a branch a long time ago that aimed to do exactly this but never got around to finishing it. It's pretty out of date, but it accomplished what you've set out to do:

Screen Shot 2021-06-25 at 9 00 00 AM

I'd love to continue that effort on this branch. One issue I was running into is support for the Widevine CDM, which is what Spotify and Apple use under-the-hood for media encryption. From what I remember, Electron doesn't support it. MusicKit added support for it in v3 but I think Spotify still doesn't support it. So we'll need to poke around and see what the status of that support is.

I don't have an Apple Dev account

Feel free to shoot me an email and I can get you access to a dev token. Thanks!

@RaulGF92
Copy link
Author

I'm glad you like my improve! Did you tried in MacOS distro? I suppose the photo you present here it was your version because it doesn't have the reflection in the ground. For me is perfect we could mix effort to release a desktop app : )

Also of import your App to a frameless transparent window, I made a taskbar menu where we could made modification or configuration for desktop side.

@mankybansal This weekend I don't have my Linux distro when I have the laptop, I rework the dependencies with yarn instead npm.

@tvillarete Doing I found a few improvents we can do. I will explain you next to this. One on my objetive is be totally transparent with your application and I have a few ideas for be not intrusive to your app.

element.style.setProperty("--my-ipod-size", "230px");
element.style.setProperty("--my-ipod-reflection-display", "none");

  • Different Sizes or Differents models: If you run my PR you could see in the top on your OS taskbar a icon menu. In here you could close or open your windows, also I would like to put diferents size or in the future diferents models. The problem with the size is you have a minimum size that couldn't be break, so if your are working in a laptop the size of the IPod is to big.

  • Problem with the drag: I was seeing how config the drag for move the IPod in any place of the screen and this feature works good, the problem occurs when you try to use the circle pad, the electron DOM thinks your are draging and i doesn't let you use the circle pad. I was tried to disabled this behaviour in Circle pad and let the drag behaviour for the other DOM elements but it doesn't work.

I send you a email and if you like you could explain the problem with electron behaviour.

Best Greatings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants