Fixing evaluators #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiwack
approved these changes
Sep 5, 2019
Endline at .gitignore Co-Authored-By: Arnaud Spiwack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1
Things done:
Box<>around the closures for aRc<Refcell<>>, so we can have cheap copies + mutability [More on the bottom].Letevaluator rule, (not recursive, at least for now).mainso it parses the input from stdio, it's useful for fast testing for now.Clonetraits to most datatypes, this should change in the future, and some shouldn't be ever copied (specially Terms)..gitignorefile.cargo fmton the whole source code.[More on the
Rc<RefCell<>>]I'm pretty convinced I'm not generating any reference cycle by doing this (notice that I'm only keeping weak pointers on the Thunks), and unless we find a case were this doesn't work, I think is a better solution than naked pointers.