Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple primitive operations #4

Merged
merged 5 commits into from
Sep 5, 2019
Merged

Simple primitive operations #4

merged 5 commits into from
Sep 5, 2019

Conversation

teofr
Copy link
Contributor

@teofr teofr commented Aug 19, 2019

I wrote a few basic operations on Num (+) and on Bool (If Then Else) and added them throughout the project (parser, term and evaluator).

There's not much to it, I also need to add a new kind of Marker for the stack, Cont, for continuations.

@teofr teofr requested a review from mboes August 19, 2019 12:37
@teofr teofr self-assigned this Aug 19, 2019
@teofr teofr marked this pull request as ready for review August 26, 2019 08:36
Copy link
Member

@aspiwack aspiwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed at changes. But they can be made in a separate PR.

src/eval.rs Show resolved Hide resolved
src/eval.rs Show resolved Hide resolved
src/eval.rs Show resolved Hide resolved
src/grammar.lalrpop Show resolved Hide resolved
@teofr teofr changed the base branch from teofr/fixing-pointers to master September 5, 2019 10:09
@teofr teofr merged commit 82cfe2f into master Sep 5, 2019
@teofr teofr deleted the teofr/simple-primitives branch September 9, 2019 08:37
@mboes mboes unassigned teofr Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants