Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skeleton not using theme variables #9712

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix: skeleton not using theme variables #9712

merged 3 commits into from
Jan 21, 2025

Conversation

magrinj
Copy link
Member

@magrinj magrinj commented Jan 17, 2025

@Weiko Weiko marked this pull request as ready for review January 17, 2025 13:46
Weiko
Weiko approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

greptile-apps[bot]
greptile-apps bot reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated skeleton loader components across the application to use theme variables for proper dark mode support, replacing hardcoded color values.

  • Replaced hardcoded colors with theme.background.tertiary and theme.background.transparent.lighter in all skeleton loaders
  • Updated UserOrMetadataLoader to use theme.background.noisy for consistent theming
  • Standardized usage of useTheme hook from @emotion/react across all loader components
  • Removed direct imports of color constants (BACKGROUND_LIGHT, BORDER_LIGHT, GRAY_SCALE) in favor of theme variables

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@magrinj magrinj force-pushed the fix/skeleton-dark-mode branch from 31b79e1 to fd72958 Compare January 21, 2025 08:08
@magrinj magrinj merged commit d4b038f into main Jan 21, 2025
47 checks passed
@magrinj magrinj deleted the fix/skeleton-dark-mode branch January 21, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magrinj @Weiko