feat: add clean suspended workspaces command #9808

etiennejouan · 2025-01-23T08:29:57Z

greptile-apps

PR Summary

This PR introduces a new automated system for managing suspended workspaces through a daily cron job that runs at 10 PM UTC.

Added CleanSuspendedWorkspacesJob in /workspace-cleaner/crons/clean-suspended-workspaces.job.ts to handle workspace cleanup based on billing inactivity
Reduced workspace inactivity thresholds in environment-variables.ts from 30/60 days to 12/14 days for notification/deletion respectively
Added start/stop cron commands in /workspace-cleaner/commands/ for managing the suspended workspace cleanup job
Added BillingSubscription to jobs.module.ts for tracking workspace billing status
TODO placeholders for email notifications to workspace members before deletion (issues Add rule to order css in styled components alphabetically #284, 282 on opportunities page data pipeline + companies + people is fetched from be #285)

_{7 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

...orkspace-manager/workspace-cleaner/commands/stop-clean-suspended-workspaces.cron.commands.ts

...rkspace-manager/workspace-cleaner/commands/start-clean-suspended-workspaces.cron.commands.ts

...ges/twenty-server/src/engine/workspace-manager/workspace-cleaner/workspace-cleaner.module.ts

...erver/src/engine/workspace-manager/workspace-cleaner/crons/clean-suspended-workspaces.job.ts

...orkspace-manager/workspace-cleaner/commands/start-clean-suspended-workspaces.cron.command.ts

...erver/src/engine/workspace-manager/workspace-cleaner/crons/clean-suspended-workspaces.job.ts

packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts

charlesBochet

Very nice! I've left comments!

...erver/src/engine/workspace-manager/workspace-cleaner/crons/clean-suspended-workspaces.job.ts

etiennejouan · 2025-01-23T15:32:33Z

@charlesBochet
We should also clean all the workspaceMembers USER_WORKSPACE_DELETION_WARNING_SENT_KEY keyValuePair when switching to activationStatus: ACTIVE. I'm not sure if it needs to be done in billing-webhook-subscription.service.ts or asynchronously.

...enty-server/src/engine/core-modules/billing/services/billing-webhook-subscription.service.ts

packages/twenty-server/src/utils/chunk-array.ts

github-actions · 2025-01-24T10:12:22Z

	Fails
🚫	`node` failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-e98acd76.json

Generated by 🚫 dangerJS against 42bf775

closes [283 sub-issue](twentyhq/core-team-issues#283) - [parent issue ](https://github.com/orgs/twentyhq/projects/1/views/3?filterQuery=sprint%3A%40current+assignee%3Aetiennejouan&pane=issue&itemId=93520456&issue=twentyhq%7Ccore-team-issues%7C179) --------- Co-authored-by: etiennejouan <[email protected]>

greptile-apps bot reviewed Jan 23, 2025

View reviewed changes

etiennejouan added the -PR: awaiting review label Jan 23, 2025