-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed ellipsis for calendar events #9823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements ellipsis handling for calendar event titles to prevent text overflow and improve UI consistency.
- Added text truncation in
packages/twenty-front/src/modules/activities/calendar/components/CalendarEventRow.tsx
withtext-overflow: ellipsis
andwhite-space: nowrap
- Set fixed width of 10 spacing units for event titles which may need adjustment to prevent overly aggressive truncation
- Maintained clickable behavior for event titles while showing truncation indicator for long text
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
overflow: hidden; | ||
text-overflow: ellipsis; | ||
white-space: nowrap; | ||
width: ${({ theme }) => theme.spacing(10)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: width: theme.spacing(10) seems very restrictive for a title. Consider using a larger value or making it responsive based on container width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lucifer4255 thanks for raising a PR. This does not seem to be the right fix, why are we forcing width: 40px? (which is what theme.spacing(10) will do)
Could you check with different title length and on different window size and provide screenshots?
I would recommend a flex approach here but it might be a bit tricky
@charlesBochet I tried with a flex approach at first but the main thing with text overflow is to ensure the containers are taking certain width but the title is not taking its parent width even if i used inherit but when i introduced a certain value whether its been 10 or 40 spacing the text got its ellipsis even if i vary window size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually works, my mistake!
Thanks a lot @Lucifer4255
Log
|
Fixed Missing ellipsis for long calendar event names twentyhq#5267 introducing width for the title Co-authored-by: Charles Bochet <[email protected]>
Fixed Missing ellipsis for long calendar event names #5267 introducing width for the title