Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmd enter to test code step #9841

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

martmull
Copy link
Contributor

As title
Use proper hotKey scope to fix the issue

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the hotkey scope handling in the CmdEnterActionButton component to fix command-enter functionality based on feature flag state.

  • Modified /packages/twenty-front/src/modules/action-menu/components/CmdEnterActionButton.tsx to use AppHotkeyScope.CommandMenuOpen when CommandMenuV2 is enabled, falling back to RightDrawerHotkeyScope.RightDrawer
  • Added feature flag check using useIsFeatureEnabled with FeatureFlagKey.IsCommandMenuV2Enabled

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martmull martmull enabled auto-merge (squash) January 24, 2025 16:41
@martmull martmull merged commit 0319722 into main Jan 24, 2025
47 checks passed
@martmull martmull deleted the fix-cmd-enter-to-test-code-step branch January 24, 2025 16:46
DeepaPrasanna pushed a commit to DeepaPrasanna/twenty that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants