Add play when locked setting #453
Conversation
Fixed a spelling error in Settings.java Play stream when locked setting Add missing default strings (warnings)
| @@ -12,7 +12,7 @@ android { | |||
| minSdk 21 | |||
| targetSdk 34 | |||
| versionCode 534 | |||
| versionName "2.11.0" | |||
| versionName "2.12.0" | |||
There was a problem hiding this comment.
Please don't change the version number. I'll change it when I make the next release.
| versionName "2.12.0" | |
| versionName "2.11.0" |
| @@ -321,7 +324,7 @@ | |||
|
|
|||
| <!-- The first letter of each line of the changelog denotes if it's about a new Version, Addition, Fix or Change and should not be translated. --> | |||
| <string-array name="changelog_lines"> | |||
| <item>V 2.11.0</item> | |||
| <item>V 2.12.0</item> | |||
There was a problem hiding this comment.
Please don't change the version number. I'll change it when I make the next release.
| <item>V 2.12.0</item> | |
| <item>V 2.11.0</item> |
| <string name="player_channel_name">Player</string> | ||
| <string name="player_channel_description">Twire Player</string> |
There was a problem hiding this comment.
These strings were used in the past but are no longer needed. If you want to resolve the warning, you should remove these keys from other translation files.
| <string name="player_channel_name">Player</string> | |
| <string name="player_channel_description">Twire Player</string> |
| public boolean getStreamPlayerAutoContinuePlayback() { | ||
| SharedPreferences preferences = getPreferences(); | ||
| return preferences.getBoolean(this.STREAM_PLAYER_AUTO_PLAYBACK, false); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why was this added? It's not used.
| public boolean getStreamPlayerAutoContinuePlayback() { | |
| SharedPreferences preferences = getPreferences(); | |
| return preferences.getBoolean(this.STREAM_PLAYER_AUTO_PLAYBACK, false); | |
| } |
| STREAM_PLAYER_AUTO_PLAYBACK = "streamPlayerAutoPlackbackOnReturn", | ||
| STREAM_PLAYER_AUTO_PLAYBACK = "streamPlayerAutoPlaybackOnReturn", |
There was a problem hiding this comment.
These strings are used as keys to save user's settings. If you change the key without migrating user's who have the old key, the setting will be lost for users who changed it.
|
Cool! I will fix it up soon. |
Play stream when locked setting Per Issue #450
Fixed a spelling error in Settings.java
Add missing default strings that was giving warnings on build