Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for single empty message when working with multiple datasets... #1155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1django
Copy link

@1django 1django commented Apr 3, 2015

.... Addresses #780 (hopefully).

As per a suggestion in the issue comments, when you are using multiple datasets, but only want to display a single empty message (instead of one per dataset), construct the typeahead like so:

$('.typeahead').typeahead({
  /* other options */
  sharedTemplates: {
    empty: '<p>Some informative empty message.</p>'
  }
});

This pull request passes npm tests, builds fine, and works for my project. However, I'm guessing there may be better ways to accomplish this...Probably due to my lack of understanding around some of the render and update related events and methods.

I'd love to see how to do this properly...

Oh, and also, I did not add a new test for the global empty message, but holler if that's required to consider this PR.

@xandor-io
Copy link

This is really helpful, have you fix the error in order to merge?

@devgnx
Copy link

devgnx commented Sep 1, 2017

#780

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


django seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants