-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract subviews on extension #186
feat: extract subviews on extension #186
Conversation
This is a great idea! I'd be curious why these can't be pulled out to separate views entirely, rather than leaving them as methods. |
I have used methods that return views because what they do is quite explicit. This limits the number of files and previews to be added in addition to putting fewer lines to the file. If it's better for the project, I can use structs to keep the homogeneity of the app |
Once we move over to |
Yeah for sure we can take get ahead, the problem with my extension of the view is the coupling of subview with the main view, I think it's better to use separate view entirely. I'll make the changes soon 🔜 |
This works as expected, if you see some improvements do not hesitate to told me @twostraws Screen.Recording.2024-05-11.at.09.02.37.mov |
This is perfect – thank you! |
I found that settings view was really big, so I decided to extract them on method returning
some View
for a better readability.If you have any feedback do not hesitate to reach me or comment the PR.
I think we can have a better naming for methods but I am not much inspired now