Added path to FeedConfiguration to make RSS endpoint configurable #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Do you think this might conflict with any work required to make #33 work? If not, I'm happy to merge it in. |
|
No, I don't think that it makes more conflicts than with the current implementation. |
|
Okay. I'll merge this now, and we can revisit once #33 moves forward. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a website to use Ignite, it helps to keep the same RSS feed URL as before.
The current implementation has hardcoded the endpoint to
{site_url}/feed.rss.This PR adds a
var path: Stringto theFeedConfigurationto make this endpoint configurable.It also works with paths like
path: "blog/rss.xml"