Clean up HMR code

tylerkahn · Jan 15, 2021 · e3066fb · e3066fb
1 parent 64165aa
commit e3066fb
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/packages/autoupdate/autoupdate_server.js b/packages/autoupdate/autoupdate_server.js
@@ -78,7 +78,6 @@ function updateVersions(shouldReloadClientProgram) {
         WebApp.calculateClientHashRefreshable(arch),
       versionNonRefreshable: AUTOUPDATE_VERSION ||
         WebApp.calculateClientHashNonRefreshable(arch),
-      // TODO: should we allow overriding versionReplaceable?
       versionReplaceable: AUTOUPDATE_VERSION ||
         WebApp.calculateClientHashReplaceable(arch)
     };
@@ -169,7 +168,6 @@ function enqueueVersionsRefresh() {
 
 // Listen for messages pertaining to the client-refresh topic.
 import { onMessage } from "meteor/inter-process-messaging";
-import { WebApp } from 'meteor/webapp';
 onMessage("client-refresh", enqueueVersionsRefresh);
 
 // Another way to tell the process to refresh: send SIGHUP signal

diff --git a/packages/ecmascript/package.js b/packages/ecmascript/package.js
@@ -26,8 +26,6 @@ Package.onUse(function (api) {
   // Runtime support for Meteor 1.5 dynamic import(...) syntax.
   api.imply('dynamic-import');
 
-  api.use('modules', 'web.browser');
-
   api.addFiles("ecmascript.js", "server");
   api.export("ECMAScript", "server");
 });

diff --git a/tools/isobuild/compiler-plugin.js b/tools/isobuild/compiler-plugin.js
@@ -1112,7 +1112,6 @@ export class PackageSourceBatch {
         self.unibuild.arch
       );
 
-    // TODO: probably safe to remove buildMode check once hot-module-replacement is debugOnly
     const isDevelopment = self.processor.buildMode === 'development';
     const usesHMRPackage = self.unibuild.pkg.name !== "hot-module-replacement" &&
       self.processor.isopackCache.uses(