Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU fixes #23

Merged
merged 8 commits into from
Sep 14, 2023
Merged

CPU fixes #23

merged 8 commits into from
Sep 14, 2023

Conversation

valentynbez
Copy link
Contributor

  • limit the number of used threads for execution on cluster nodes
  • properly deserialise CUDA/CPU
  • remove bug that prevented --help
  • update needed Intel dependencies for CPU

@mortonjt
Copy link
Collaborator

Hi @valentynbez thanks for the pull request! From a first glance, this looks good.

Out of curiosity, what errors are you running into when you don't install mkl=2021 mkl_fft? We didn't need to install these dependencies (abet need to check the our pre-configuration).

@valentynbez
Copy link
Contributor Author

valentynbez commented Sep 14, 2023 •
edited
Loading

See relevant issues:

mortonjt
mortonjt reviewed Sep 14, 2023
View reviewed changes
@valentynbez @mortonjt
docs: update readme
de3fbdb 
Co-authored-by: Jamie Morton <[email protected]>
@mortonjt
Copy link
Collaborator

Great. I think we can merge as is. Thanks for your contribution!

@mortonjt mortonjt merged commit bbec50e into tymor22:master Sep 14, 2023
@valentynbez valentynbez mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortonjt mortonjt mortonjt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentynbez @mortonjt