Alertingfix (#348)

Co-authored-by: Dominic Wong <[email protected]>
type-checker · Sep 16, 2020 · 43a9d7f · 43a9d7f
1 parent cf0ef6c
commit 43a9d7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/alert/handler/alert.go b/alert/handler/alert.go
@@ -48,6 +48,7 @@ func NewAlert(store store.Store) *Alert {
 	if len(gaPropertyID) == 0 {
 		log.Errorf("Google Analytics key (property ID) is missing")
 	}
+	log.Infof("Slack enabled: %v", slackEnabled)
 
 	return &Alert{
 		slackClient:  slack.New(slackToken),
@@ -84,7 +85,7 @@ func (e *Alert) ReportEvent(ctx context.Context, req *alert.ReportEventRequest,
 		if err != nil {
 			return err
 		}
-		msg := fmt.Sprintf("Error event received:\n```\n%v\n```", string(jsond))
+		msg := fmt.Sprintf("Event received:\n```\n%v\n```", string(jsond))
 		_, _, _, err = e.slackClient.SendMessage("errors", slack.MsgOptionUsername("Alert Service"), slack.MsgOptionText(msg, false))
 		if err != nil {
 			return err

diff --git a/signup/handler/signup.go b/signup/handler/signup.go
@@ -281,8 +281,8 @@ func (e *Signup) verify(ctx context.Context, req *signup.VerifyRequest, rsp *sig
 func (e *Signup) CompleteSignup(ctx context.Context, req *signup.CompleteSignupRequest, rsp *signup.CompleteSignupResponse) error {
 	err := e.completeSignup(ctx, req, rsp)
 	val := 0
-	label := "Completed signup"
-	if err == nil {
+	label := fmt.Sprintf("Successful signup: %v", req.Email)
+	if err != nil {
 		val = 1
 		label = fmt.Sprintf("Error for %v: %v", req.Email, err)
 	}