Update Bazel version and dependencies #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is fixed: https://github.com/typedb/typedb-docs/tree/update-typedb-dependencies |
farost
commented
May 8, 2025
| @@ -36,32 +33,11 @@ filegroup( | |||
| visibility = ["//visibility:public"] | |||
| ) | |||
|
|
|||
| filegroup( | |||
| name = "autolink-keywords", | |||
| visibility = ["//visibility:public"] | ||
| ) | ||
|
|
||
| native_typedb_artifact( |
There was a problem hiding this comment.
It will be easy to readd it if needed
|
|
||
| ################################ | ||
| # Load @vaticle_dependencies # | ||
| # Load @typedb_dependencies # |
There was a problem hiding this comment.
Still many unused rules, but I don't see a need to clean up everything completely now. It will be easier to add new things.
I know that it's generally bad practice and it's better to minimize things, but I don't really want to spend time on careful cleanup now. It's in sync with other repos, it already makes our lives better.
alexjpwalker
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix CI builds by updating Bazel dependencies.
Implementation
6.2.0to unblock dependency upgrade and match other maintained repositories;