-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated ?
syntax
#186
Conversation
Scala 2.13.6 and 2.12.14 will interpret `?` as a wildcard when using the `-Xsource:3` flag (cf scala/scala#9560)). This means that the old kind-projector syntax will no longer work, so it seems like a good time to remove it. This will also allow us to compile more of the community-build with `-Xsource:3` enabled (cf scala/scala-dev#769). Sincet this is a breaking change, we also bump the version to 0.12.0-SNAPSHOT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin is widespread, but not transitive, so I think the breaking change won't hurt much. And I suspect the Venn diagram of kind projectors and fatal warners has a good overlap, so it may even just drop in for most people.
@neko-kai care to explain your objection? |
@SethTisue Same as before in #120, I'm still using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Staying on an old version of kind-projector appears like an acceptable workaround to me.
I can release on Monday, unless someone thinks it's urgent. |
Like scala#9721, the goal here is to ease cross-compilation between Scala 2 and 3 code as we prepare for `_` as wildcard to be deprecated in Scala 3 (cf scala/scala3#5379). This is technically a source-breaking change, but using a type named ? without backticks is deprecated since 2.13.6 (scala#9626) and defining a type named ? without backticks is disallowed since 2.13.7 (scala#9735). The only known user of ? as a type name was the kind-projector plugin, but support for this syntax was removed from the plugin a year ago (typelevel/kind-projector#186), so I believe this change won't be disruptive.
Scala 2.13.6 and 2.12.14 will interpret
?
as a wildcard when using the-Xsource:3
flag (cf scala/scala#9560). Thismeans that the old kind-projector syntax will no longer work, so it
seems like a good time to remove it. This will also allow us to compile
more of the community-build with
-Xsource:3
enabled (cfscala/scala-dev#769).
Sincet this is a breaking change, we also bump the version to
0.12.0-SNAPSHOT.