Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pioneering-rlj:0.6.0 #1399

Merged
merged 1 commit into from
Dec 9, 2024
Merged

pioneering-rlj:0.6.0 #1399

merged 1 commit into from
Dec 9, 2024

Conversation

daskol
Copy link
Contributor

@daskol daskol commented Dec 7, 2024

I am submitting

  • a new package
  • an update for a package

Description: Template for Reinforcemnt Learning Conference/Journal (RLC/RLJ) (see details in upstream daskol/typst-templates#27 and daskol/typst-templates#28).

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Dec 7, 2024
@daskol daskol force-pushed the daskol/rlj branch 3 times, most recently from 1d3ebbe to d333789 Compare December 7, 2024 11:06
@daskol daskol marked this pull request as ready for review December 7, 2024 11:07
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the package :) Just a small thing you may want to fix about your thumbnail, and it should be good to merge.

packages/preview/pioneering-rlj/0.6.0/thumbnail.png Outdated Show resolved Hide resolved
packages/preview/pioneering-rlj/0.6.0/rlj.typ Outdated Show resolved Hide resolved
@daskol
Copy link
Contributor Author

daskol commented Dec 9, 2024

Thank you for your comments. Fixed.

@elegaanz
Copy link
Member

elegaanz commented Dec 9, 2024

Thanks!

@elegaanz elegaanz merged commit eaf8f98 into typst:main Dec 9, 2024
2 checks passed
@daskol daskol deleted the daskol/rlj branch December 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants