Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unofficial-hka-thesis:1.0.0 #1493

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

unofficial-hka-thesis:1.0.0 #1493

wants to merge 12 commits into from

Conversation

AnsgarLichter
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

This template contains a template to write a bachelor's or master's thesis at the University of Applied Sciences or with a little bit of customization also on other universities. Therefore, this templates helps to ease the setup process when starting a thesis.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Dec 30, 2024
@elegaanz
Copy link
Member

elegaanz commented Jan 8, 2025

Hello, and thank you for submitting this package. Two things:

  • first, you seem to use camelCase to name your functions and arguments. This is fine, but it is not the most common convention in the Typst world (we tend to prefer kebab-case). It would be appreciated if you renamed them to follow this standard (but it is not mandatory, and if you have a strong preference for camelCase, this is acceptable as well).
  • also, you seem to use an old version of glossarium in template/chapters/1_introduction.typ, could you update it to 0.5.1 to avoid depending on deprecated functions?

@AnsgarLichter
Copy link
Contributor Author

Thank you for your feedback - I did the following changes:

  • used kebab-case, hope I didn't miss a variable
  • Updated the 1 reference to the old version of glossarium, thanks for spotting this oversight :)

elegaanz
elegaanz reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. There are a few more occurrences of camelCase that are left.

packages/preview/unofficial-hka-thesis/1.0.0/lib.typ Outdated
)
}

#let mainBody(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in camelCase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/preview/unofficial-hka-thesis/1.0.0/modules/titlepage.typ Outdated
@@ -0,0 +1,103 @@
#let openTitlePage(settings: ()) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/preview/unofficial-hka-thesis/1.0.0/modules/titlepage.typ Outdated
set par(leading: 1em)
}

#let finishTitlePage(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/preview/unofficial-hka-thesis/1.0.0/modules/titlepage.typ Outdated
place-of-work: "",
supervisor: "",
advisor: "",
startDate: none,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/preview/unofficial-hka-thesis/1.0.0/modules/titlepage.typ Outdated
) = {

v(5mm)
align(center, text(font: settings.fontHeading, 1.9em, weight: 700, "University of Applied Sciences Karlsruhe"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values in settings seem to be in camelCase as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AnsgarLichter
Copy link
Contributor Author

Thanks for spotting my oversights ... I hope I fixed them all now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elegaanz elegaanz elegaanz left review comments

Assignees
No one assigned
Labels
new A new package submission.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnsgarLichter @elegaanz