hagaki:0.1.0 #1505
hagaki:0.1.0 #1505
Conversation
There was a problem hiding this comment.
Thank you for submitting this package. In addition to the comments below, could you please change the name to something less canonical? Ideally, package names should be unique enough to allow for alternatives without one of them being seen as "the" package for that purpose. If you lack inspiration, you can simply add an adjective to the current name.
| /// - path (string): The path to the CSV file, e.g., "jyusyoroku.csv". | ||
| /// - lastNameColumn (integer): The column number for the last name, e.g., 0. | ||
| /// - firstNameColumn (integer): The column number for the first name, e.g., 1. | ||
| /// - postCodeColumn (integer): The column number for the post code, e.g., 2. | ||
| /// - addressColumn (integer): The column number for the address, e.g., 3. | ||
| /// - myLine (number): The line number for the sender, e.g., 1. |
There was a problem hiding this comment.
The names of the parameters here seem outdated.
| my-line: 1, | ||
| debug: false, | ||
| ) = { | ||
| let lines = csv(path) |
There was a problem hiding this comment.
This will probably not work as expected, since you can only access files from your package if you make the csv call here. Instead, you should ask the user of the package to pass a call to csv(path) instead of just path as a parameter.
I am submitting
Allows batch printing address labels on Japanese Hagaki paper (from a CSV file).
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE