Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pigmentpedia:0.3.0 #1534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

neuralpain
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Fixed issue with scoped search in #1495 and added visual improvements.

@elegaanz
Copy link
Member

elegaanz commented Jan 9, 2025

Thanks for this update :) The only remark I have before merging is that pigment names are in Uppercase-Kebab-Case, which feels inconsistent with the rest of the Typst ecosystem (where kebab-case is by far the most common convention, with only a few packages using camelCase or snake_case). It would be nice if you could change the names so that they all use lowercase-kebab-case. If you really prefer to keep the upper case version please tell me, it is not a hard requirement to follow this convention to have your package merged, I'm just making a suggestion to improve your package.

@elegaanz elegaanz added the update A package update. label Jan 9, 2025
@neuralpain
Copy link
Contributor Author

pigment names are in Uppercase-Kebab-Case, which feels inconsistent with the rest of the Typst ecosystem

Yeah, the naming convention of the pigments was a difficult decision for me. I thought about staying within the preferred kebab-case, however, since they were actual names, I was on the fence as to whether or not I should change their appearance within pigmentpedia.

Let me think about it some more and I'll let you know when I'm ready for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update A package update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants