Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace academic reference & lint #443

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

brucecrevensten
Copy link
Member

Closes #440

Read that ticket, go to the Temperature Indices section of the tool and verify that the text is correct + links go where expected!

@charparr
Copy link
Member

charparr commented Nov 1, 2024

@brucecrevensten could you please help me with the dev setup for the EDS?
I'm trying to run the app with the API running locally like this:

export SNAP_API_URL=http://localhost:5000
export RASDAMAN_URL=https://apollo.snap.uaf.edu/rasdaman/ows
npm run dev

but getting a weird error / garbled footer when I try to generate a data report like this:
image

I'm probably missing something basic in the set up here.

Copy link
Contributor

@BobTorgerson BobTorgerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! The changed links go to the correct webpages.

@BobTorgerson
Copy link
Contributor

BobTorgerson commented Nov 6, 2024

@charparr Instead of trying to set up a development instance of the API, try using the defaults for those environment variables and run the ArcticEDS by itself. The text and URLs that have changed shouldn't be affected by which API and Rasdaman server the development instance is pointed at.

@charparr
Copy link
Member

charparr commented Nov 6, 2024

Got it, thanks Bob! This looks good, and references work as expected.

@charparr charparr merged commit bc8fbd4 into main Nov 6, 2024
@charparr charparr deleted the update_academic_reference branch November 6, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Academic References for Degree Day Section of Report
3 participants