Uses the API to determine the maximum year and month that we have data for #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le MAX_MONTH for setting maximum month selector.
…ynamically for the components.
brucecrevensten
requested changes
Jan 8, 2025
src/shared.js
Outdated
|
|
||
| export let xrange = [] | ||
|
|
||
| export async function getMaxYearAndMonth() { |
There was a problem hiding this comment.
I think this logic all belongs in the Store now because it's doing an async request which is exactly what the shared state / action in Stores is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a new endpoint on the API that allows for this code to dynamically update its maximum year and month based on the data available within our data server. Currently, that maximum is year = 2024 and month = 6, but the next time we update the sea ice data, it will automatically recognize that there is new data to be displayed and adjust the year slider, month selector, and xrange for the charts accordingly.
To test:
Have this version of the API running locally: ua-snap/data-api#508
export VITE_SNAP_API_URL=http://localhost:5000
export VITE_WMS_URL=https://zeus.snap.uaf.edu/rasdaman/ows
npm run dev
Notice that the year slider has a maximum of 2024 and you can't go past the month of June. The charts should also all display properly given the correct range of values.
Closes #84