Skip to content

Commit

Permalink
travis: Fix lint
Browse files Browse the repository at this point in the history
Turns out `make lint` failures were not actually breaking the build
because we added an `|| echo "Skipping lint"` which would get called
when `make lint` failed.

This should cause lint failures as expected.
  • Loading branch information
abhinav committed Jan 3, 2018
1 parent 5ee0125 commit fb49d80
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ cache:
install:
- make dependencies
script:
- test "$LINT" -eq 1 && make lint || echo "Skipping lint"
- test -z "$LINT" && echo "Skipping lint" || make lint
- make ci
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ dependencies:
glide --version || go get -u -f github.com/Masterminds/glide
glide install
@echo "Installing uber-license tool..."
update-license || go get -u -f go.uber.org/tools/update-license
update-license -h || go get -u -f go.uber.org/tools/update-license
@echo "Installing golint..."
golint -h || go get -u -f github.com/golang/lint/golint

.PHONY: lint
lint:
Expand Down

0 comments on commit fb49d80

Please sign in to comment.