Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more bailouts for raw types #1153

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Add more bailouts for raw types #1153

merged 2 commits into from
Mar 4, 2025

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Mar 1, 2025

Fixes #1151

The extra check in CheckIdenticalNullabilityVisitor is not needed to fix this bug but seemed like a prudent addition.

@msridhar msridhar requested review from yuxincs and akshayutture March 1, 2025 20:31
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (baf8f77) to head (3304fff).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...way/generics/CheckIdenticalNullabilityVisitor.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1153      +/-   ##
============================================
- Coverage     88.16%   88.15%   -0.02%     
- Complexity     2281     2282       +1     
============================================
  Files            87       87              
  Lines          7461     7463       +2     
  Branches       1491     1492       +1     
============================================
+ Hits           6578     6579       +1     
  Misses          445      445              
- Partials        438      439       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 635ecd2 into master Mar 4, 2025
10 of 12 checks passed
@msridhar msridhar deleted the issue-1151 branch March 4, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants