-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex stuff #529
Merged
Merged
Add regex stuff #529
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4a413d0
Add regex stuff
ketkarameya f32bb95
Update on "Add regex stuff"
ketkarameya 80adac8
Update on "Add regex stuff"
ketkarameya 786dee6
Update on "Add regex stuff"
ketkarameya 2b0b086
Update on "Add regex stuff"
ketkarameya 6857c6e
Update on "Add regex stuff"
ketkarameya 99fd457
Update on "Add regex stuff"
ketkarameya 8ed0493
Update on "Add regex stuff"
ketkarameya c55bca1
Update on "Add regex stuff"
ketkarameya 99d2218
Update on "Add regex stuff"
ketkarameya 1454962
Update on "Add regex stuff"
ketkarameya 3ac21b0
Update on "Add regex stuff"
ketkarameya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update on "Add regex stuff"
[ghstack-poisoned]
- Loading branch information
commit 80adac885670b1d0249b305be06cfbe498f5b40c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,18 +41,16 @@ impl CGPattern { | |
} | ||
|
||
pub(crate) fn extract_regex(&self) -> String { | ||
let mut _val = self.pattern(); | ||
_val.replace_range(..4, "rgx "); | ||
let mut _val = &self.pattern()[4..]; | ||
_val.to_string() | ||
} | ||
} | ||
|
||
impl Validator for CGPattern { | ||
fn validate(&self) -> Result<(), String> { | ||
if self.pattern().starts_with("rgx ") { | ||
let mut _val = self.pattern(); | ||
_val.replace_range(..4, "rgx "); | ||
return Regex::new(_val.as_str()) | ||
let mut _val = &self.pattern()[4..]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we have this logic here and in |
||
return Regex::new(_val) | ||
.map(|_| Ok(())) | ||
.unwrap_or(Err(format!("Cannot parse the regex - {_val}"))); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
test-resources/java/regex_based_matcher/configurations/rules.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[[rules]] | ||
name = "replace_call" | ||
query = """rgx (?P<n>foo\\(\\))""" | ||
replace_node = "n" | ||
replace = "Foo" |
10 changes: 10 additions & 0 deletions
10
test-resources/java/regex_based_matcher/expected/Sample.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.uber.piranha; | ||
|
||
class A { | ||
|
||
void foobar() { | ||
int total = Foo; | ||
System.out.println(total); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.uber.piranha; | ||
|
||
class A { | ||
|
||
void foobar() { | ||
int total = foo(); | ||
System.out.println(total); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.