Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for compatibility with Go 1.16 #821

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Fixes for compatibility with Go 1.16 #821

merged 5 commits into from
Mar 12, 2021

Conversation

cinchurge
Copy link
Collaborator

@cinchurge cinchurge commented Mar 3, 2021

Ref https://golang.org/doc/go1.16#go-command

go modules are now enabled by default, so go get would fail
without explicitly turning it off via GO111MODULE=off

additionally, go build -i now returns an error during tests. since
that flag has been deprecated, remove it so the tests can pass.

@cinchurge cinchurge requested a review from prashantv March 3, 2021 19:49
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #821 (59254b6) into dev (61d863a) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #821      +/-   ##
==========================================
+ Coverage   87.49%   87.79%   +0.29%     
==========================================
  Files          42       42              
  Lines        3702     3702              
==========================================
+ Hits         3239     3250      +11     
+ Misses        344      333      -11     
  Partials      119      119              
Impacted Files Coverage Δ
preinit_connection.go 92.12% <0.00%> (-1.58%) ⬇️
peer.go 93.47% <0.00%> (-0.44%) ⬇️
connection.go 87.56% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d863a...59254b6. Read the comment docs.

@prashantv
Copy link
Contributor

Can we also update .travis.yml to test against stable and oldstable?

@cinchurge cinchurge merged commit 7e7465b into dev Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants