Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor field: vdims #214

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Refactor field: vdims #214

merged 8 commits into from
Nov 23, 2022

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Nov 16, 2022 •
edited
Loading

  • renamed: dim -> nvdim
  • renamed: components -> vdims
  • removed: coordinate_field
  • removed: typesystem decorator

Todo

  • check doctests
  • update docstrings

@lang-m lang-m requested review from swapneelap and samjrholt and removed request for swapneelap and samjrholt November 16, 2022 17:51
@lang-m
Copy link
Member Author

lang-m commented Nov 16, 2022

We have to think about how to change the docstrings (e.g. when talking about "field components").

@lang-m lang-m requested a review from samjrholt November 22, 2022 16:42
@samjrholt
Copy link
Member

@lang-m looks good, just take a look at the field rotator as discussed. I will take a look through the documentation and let you know when I'm done.

@lang-m
Copy link
Member Author

lang-m commented Nov 23, 2022

@samjrholt I have fixed the FieldRotator and tools where failures are related to nvdim or vdims.

@lang-m
Copy link
Member Author

lang-m commented Nov 23, 2022

@samjrholt You can merge the PR when you are done.

@samjrholt samjrholt merged commit 80a99de into refactor_master Nov 23, 2022
@samjrholt samjrholt deleted the refactor_field_vdims branch November 23, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjrholt samjrholt Awaiting requested review from samjrholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lang-m @samjrholt