Skip to content

Commit

Permalink
fix: update init arguments for SourceDef and SourceAttributes class t…
Browse files Browse the repository at this point in the history
…o adopt KafkaSource registry (feathr-ai#1174)
  • Loading branch information
thurstonchen authored May 25, 2023
1 parent 9ecb7eb commit 70b434d
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions registry/purview-registry/registry/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def __init__(self,
qualified_name: str,
name: str,
type: str,
path: str,
path: str = None,
preprocessing: Optional[str] = None,
event_timestamp_column: Optional[str] = None,
timestamp_format: Optional[str] = None,
Expand Down Expand Up @@ -698,9 +698,12 @@ def to_attr(self) -> ProjectAttributes:
class SourceDef:
def __init__(self,
name: str,
path: str,
type: str,
qualified_name: str = "",
path: str = None,
brokers: List[str] = None,
topics: List[str] = None,
schema: str = None,
preprocessing: Optional[str] = None,
event_timestamp_column: Optional[str] = None,
timestamp_format: Optional[str] = None,
Expand All @@ -709,6 +712,9 @@ def __init__(self,
self.name = name
self.path = path
self.type = type
self.brokers = brokers
self.topics = topics
self.schema = schema
self.preprocessing = preprocessing
self.event_timestamp_column = event_timestamp_column
self.timestamp_format = timestamp_format
Expand Down

0 comments on commit 70b434d

Please sign in to comment.